Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat Python code so it would pass linting checks in moz-central. #6519

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mhammond
Copy link
Member

This was done by:

  • Temporarily copying pyproject.toml from the root of m-c to the root here.
  • Running ruff check --fix --select I {path}
  • Running ruff check {path} to see what ruff didn't fix, and hand-fixing them.
  • Running black {path} for final "correct" formatting.
  • Removing pyproject.toml

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

This was done by:
* Temporarily copying pyproject.toml from the root of m-c to the root here.
* Running `ruff check --fix --select I {path}`
* Running `ruff check {path}` to see what ruff didn't fix, and hand-fixing them.
* Running `black {path}` for final "correct" formatting.
* Removing pyproject.toml

ruff/black: taskcluster
@mhammond mhammond requested a review from bendk December 10, 2024 18:50
@mhammond
Copy link
Member Author

/ci full

@mhammond
Copy link
Member Author

/taskcluster ci full

@mhammond mhammond requested a review from Standard8 December 14, 2024 04:30
@mhammond mhammond added this pull request to the merge queue Dec 17, 2024
Merged via the queue into mozilla:main with commit 5451b9b Dec 17, 2024
40 checks passed
@mhammond mhammond deleted the push-vmrzvykwowkt branch December 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants